Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli: Remove warnings from version list output #7361

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Cli: Remove warnings from version list output #7361

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e61f3fa
NpmPackagesUpdater: RemoveWarningsFromVersionShowOutput
yekalkan Jan 20, 2021
fa1457a
refactor RemoveWarningsFromVersionShowOutput
ebicoglu Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/NpmPackagesUpdater.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,11 +345,20 @@ protected virtual void RunNpmInstall(string fileDirectory)

protected virtual List<string> GetPackageVersionList(JProperty package)
{
var versionListAsJson = CmdHelper.RunCmdAndGetOutput($"npm show {package.Name} versions");
var output = CmdHelper.RunCmdAndGetOutput($"npm show {package.Name} versions --json");

var versionListAsJson = ExtractVersions(output);

return JsonConvert.DeserializeObject<string[]>(versionListAsJson)
.OrderByDescending(SemanticVersion.Parse, new VersionComparer()).ToList();
}

protected virtual string ExtractVersions(string output)
{
var arrayStart = output.IndexOf('[');
return output.Substring(arrayStart, output.IndexOf(']') - arrayStart + 1);
}

protected virtual bool SpecifiedVersionExists(string version, JProperty package)
{
var versionList = GetPackageVersionList(package);
Expand Down