Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wait services #6798

Merged
merged 7 commits into from
Dec 24, 2020
Merged

add wait services #6798

merged 7 commits into from
Dec 24, 2020

Conversation

muhammedaltug
Copy link
Contributor

@muhammedaltug muhammedaltug commented Dec 24, 2020

  • remove ngxs from api interceptor and loader-bar component
  • remove filter input from loader bar component
    Breaking Changes:
  • Filter input removed from abp-loader-bar component. Use HttpWaitService's addFilter and removeFilter methods.
  • StartLoader and StopLoader actions removed. Use HttpWaitService's addRequest and removeRequest methods.

- remove ngxs from api interceptor and loader-bar component
- remove filter input from loader bar component
Comment on lines 5 to 6
import { RouterWaitService } from '../../../../../core/src/lib/services/router-wait.service';
import { HttpWaitService } from '../../../../../core/src/lib/services/http-wait.service';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { RouterWaitService } from '../../../../../core/src/lib/services/router-wait.service';
import { HttpWaitService } from '../../../../../core/src/lib/services/http-wait.service';
import { RouterWaitService, HttpWaitService } from '@abp/ng.core';

@armanozak armanozak merged commit 6066f0d into rel-4.1 Dec 24, 2020
@armanozak armanozak deleted the feat/6733 branch December 24, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants