Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tntwist/multi lingual entities #5774

Closed
wants to merge 715 commits into from
Closed

Tntwist/multi lingual entities #5774

wants to merge 715 commits into from

Conversation

tntwist
Copy link
Contributor

@tntwist tntwist commented Oct 12, 2020

Hi @realLiangshiwei and @hikalkan,

I solved the breaking index for the language property of the translations and added AutoMapper-Functionalities for the MultiLingual-Entities. I packed the AutoMapper code in the MultiLingualObject Module since these extensions are not relevant for devs who don`t need the MultiLingualEntities.

It would be nice if you review these changes.

Greetings

ebicoglu and others added 30 commits October 1, 2020 15:07
Corrected text referencing multiple RabbitMQ server in the Kafka integration guide.
Update Distributed-Event-Bus-Kafka-Integration.md
Documented How to Convert Angular Apps to PWAs
hikalkan and others added 28 commits October 11, 2020 19:53
…lper

Fix HTML coding error in AbpInputTagHelperService
…-article

Article: Replacing Email Template and Sending Emails
@realLiangshiwei
Copy link
Member

Hi,

Thanks for your contribution, But I think there are the following problems

  1. Your PR contains a lot of unwanted submissions.

  2. ABP abstracts object mapping and multilingual entity project should not depend on the Automapper project. Actually, I considered your implementation, but I didn’t decide to do it.

  3. I think this way has some problems, as you see, the unit tests get failed. We are considering a better implementation: Consider supporting Automapper dependency injection #5288

            Configure<AbpAutoMapperOptions>(options =>
           {
               var sp = context.Services.BuildServiceProvider();
               options.Configurators.Add(ct => ct.MapperConfiguration.ConstructServicesUsing(sp.GetService));
           });

So, I will close the PR, You can write your suggestion here #5265.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.