Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blazor message refactor #5740

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Blazor message refactor #5740

merged 2 commits into from
Oct 8, 2020

Conversation

stsrki
Copy link
Contributor

@stsrki stsrki commented Oct 8, 2020

#5551

  • Removed UiMessageNotifierService
  • Use of Action for setting the message options
  • Localization
  • Add CenterMessage to options

@hikalkan hikalkan merged commit 0319cdc into dev Oct 8, 2020
@hikalkan hikalkan deleted the blazor-message-refactor branch October 8, 2020 10:49
@hikalkan
Copy link
Member

hikalkan commented Oct 8, 2020

It would be better to allow to set the options in a global way, so people can set the options globally, then override per method call.
I've created an issue in the backlog: #5742 We do it later.

@hikalkan hikalkan added this to the 3.3-preview milestone Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
abp-framework enhancement ui-blazor
Projects
None yet
Milestone
3.3-preview
Development

Successfully merging this pull request may close these issues.
2 participants
@stsrki @hikalkan