Support to return Stream from application services & handle on the Dynamic C# proxying #5733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot. I will deeply review this and comment on. |
|
Your implementation seems pretty good. I will test myself, maybe a little refactor, then I will merge. |
hikalkan
changed the title
|
@alexandru-bagu Excuse me, how to get the file name in this feature? |
|
@Rwing Please create a new issue. |
a stream does now have a name as it's supposed to be just a string of bytes. you can include the name as an additional parameter to the app service method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #5727
Usage example can be found here: https://github.com/alexandru-bagu/abp-remote-stream-test