Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formating settings for ABP solution based on the default C# settings #5681

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

stsrki
Copy link
Contributor

@stsrki stsrki commented Oct 2, 2020

Added .editorconfig to the ABP solution. It's used to have consistent code-style settings accross all projects.

I tested it on multiple .cs files and it's working without any modifications on current files except for some smaller and inconsistent spacing on the current code which it's trying to fix. I found this behavior good as it will clean the code in time.

Please test before merging!

@stsrki stsrki requested a review from hikalkan October 2, 2020 09:10
@maliming maliming added this to the 3.3-preview milestone Oct 4, 2020
@hikalkan hikalkan merged commit a4cf535 into dev Oct 5, 2020
@hikalkan hikalkan deleted the dev-stsrki-editorconfig branch October 5, 2020 10:43
@hikalkan
Copy link
Member

hikalkan commented Oct 5, 2020

Actually, we should be able to apply this to all solutions. Is there a way to put this to the root folder of the abp repository and use from all the solutions? I don't want to duplicate...

@stsrki
Copy link
Contributor Author

stsrki commented Oct 5, 2020

As far as I know, it works only from the solution folder and for per-project, depending on where .editorconfig is placed. I don't think it's possible to use it on multiple solutions. Maybe you can try adding it as a file-reference in the other solution? never tried that to be fair...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants