Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the current language problems in Session State #5609

Merged
merged 4 commits into from
Sep 25, 2020
Merged

Fixed the current language problems in Session State #5609

merged 4 commits into from
Sep 25, 2020

Conversation

mehmet-erim
Copy link
Contributor

Resolves #5229

@mehmet-erim mehmet-erim added this to the 3.2-final milestone Sep 25, 2020
@mehmet-erim mehmet-erim changed the base branch from dev to rel-3.2 September 25, 2020 09:44
bnymncoskuner
bnymncoskuner approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@bnymncoskuner bnymncoskuner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armanozak armanozak merged commit d4f106c into rel-3.2 Sep 25, 2020
@armanozak armanozak deleted the fix/5229 branch September 25, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhammedaltug muhammedaltug muhammedaltug approved these changes

@bnymncoskuner bnymncoskuner bnymncoskuner approved these changes

@armanozak armanozak Awaiting requested review from armanozak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2-final
Development

Successfully merging this pull request may close these issues.

[angular] DynamicLayoutComponent didn't work when with a long time APP_INITIALIZER
4 participants
@mehmet-erim @bnymncoskuner @muhammedaltug @armanozak