Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: french localization #5494

Merged
merged 5 commits into from
Sep 22, 2020
Merged

feat: french localization #5494

merged 5 commits into from
Sep 22, 2020

Conversation

badre429
Copy link
Contributor

No description provided.

@badre429 badre429 mentioned this pull request Sep 18, 2020
Closed
@maliming
Copy link
Member

hi @badre429

Could you create PR in dev branch?

@badre429
Copy link
Contributor Author

@maliming
hi if possible we need french localization for 3.2 since localization is not has no impact on behavior of rc

@maliming maliming requested a review from hikalkan September 19, 2020 11:48
@maliming maliming added this to the 3.2-final milestone Sep 21, 2020
@hikalkan
Copy link
Member

I agree about to merge this to rel-3.2. In fact, we should always complete the localizations in the preview period.
So, thank you @badre429

@maliming it seems OK to me, can you merge, then test it?

@hikalkan hikalkan requested a review from maliming September 22, 2020 09:29
@maliming
Copy link
Member

I'll test it in next RC.

@maliming maliming merged commit 2253b12 into abpframework:rel-3.2 Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikalkan hikalkan hikalkan approved these changes

@maliming maliming Awaiting requested review from maliming

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2-final
Development

Successfully merging this pull request may close these issues.
3 participants
@badre429 @maliming @hikalkan