Created ReplaceableComponentsService and used it instead of ReplaceableComponentsState #5333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @Injectable({ providedIn: 'root' }) | ||
| export class ReplaceableComponentsService { | ||
| private state: InternalStore<ReplaceableComponents.ReplaceableComponent[]>; |
There was a problem hiding this comment.
Store would be better naming
Suggested change
| private state: InternalStore<ReplaceableComponents.ReplaceableComponent[]>; | |
| private store: InternalStore<ReplaceableComponents.ReplaceableComponent[]>; |
| } | ||
|
|
||
| get onUpdate$(): Observable<ReplaceableComponents.ReplaceableComponent[]> { | ||
| return this.state.sliceUpdate(state => state); |
There was a problem hiding this comment.
Suggested change
| return this.state.sliceUpdate(state => state); | |
| return this.store.sliceUpdate(state => state); |
| } | ||
|
|
||
| constructor(private ngZone: NgZone, private router: Router) { | ||
| this.state = new InternalStore([]); |
There was a problem hiding this comment.
Suggested change
| this.state = new InternalStore([]); | |
| this.store = new InternalStore([]); |
| } | ||
|
|
||
| add(replaceableComponent: ReplaceableComponents.ReplaceableComponent, reload?: boolean): void { | ||
| let replaceableComponents = this.state.state; |
There was a problem hiding this comment.
Suggested change
| let replaceableComponents = this.state.state; | |
| let replaceableComponents = this.store.state; |
| replaceableComponents = [...replaceableComponents, replaceableComponent]; | ||
| } | ||
|
|
||
| this.state.patch(replaceableComponents); |
There was a problem hiding this comment.
Suggested change
| this.state.patch(replaceableComponents); | |
| this.store.patch(replaceableComponents); |
armanozak
reviewed
Sep 9, 2020
| @@ -69,6 +56,7 @@ export class ReplaceableComponentsState { | |||
| replaceableComponents, | |||
| }); | |||
|
|
|||
| if (reload) this.reloadRoute(); | |||
| console.log(this.service); | |||
There was a problem hiding this comment.
Suggested change
| console.log(this.service); |
|
|
||
| @Injectable({ providedIn: 'root' }) | ||
| export class ReplaceableComponentsService { | ||
| private state: InternalStore<ReplaceableComponents.ReplaceableComponent[]>; |
There was a problem hiding this comment.
Suggested change
| private state: InternalStore<ReplaceableComponents.ReplaceableComponent[]>; | |
| private state = new InternalStore<ReplaceableComponents.ReplaceableComponent[]>([]); |
| } | ||
|
|
||
| constructor(private ngZone: NgZone, private router: Router) { | ||
| this.state = new InternalStore([]); |
There was a problem hiding this comment.
Suggested change
| this.state = new InternalStore([]); |
Comment on lines
46
to
58
| let replaceableComponents = this.state.state; | ||
|
|
||
| const index = replaceableComponents.findIndex( | ||
| component => component.key === replaceableComponent.key, | ||
| ); | ||
|
|
||
| if (index > -1) { | ||
| replaceableComponents[index] = replaceableComponent; | ||
| } else { | ||
| replaceableComponents = [...replaceableComponents, replaceableComponent]; | ||
| } | ||
|
|
||
| this.state.patch(replaceableComponents); |
There was a problem hiding this comment.
Suggested change
| let replaceableComponents = this.state.state; | |
| const index = replaceableComponents.findIndex( | |
| component => component.key === replaceableComponent.key, | |
| ); | |
| if (index > -1) { | |
| replaceableComponents[index] = replaceableComponent; | |
| } else { | |
| replaceableComponents = [...replaceableComponents, replaceableComponent]; | |
| } | |
| this.state.patch(replaceableComponents); | |
| let found = 0; | |
| const replaceableComponents: ReplaceableComponents.ReplaceableComponent[] = []; | |
| this.state.state.forEach(component => { | |
| if (component.key === replaceableComponent.key) { | |
| replaceableComponents.push(replaceableComponent); | |
| found++; | |
| return; | |
| } | |
| replaceableComponents.push(component); | |
| }); | |
| if (!found) replaceableComponents.push(replaceableComponent); | |
| this.state.patch(replaceableComponents); |
npm/ng-packs/packages/core/src/lib/services/replaceable-components.service.ts
Outdated
Show resolved
Hide resolved
…ents.service.ts Co-authored-by: Levent Arman Özak <[email protected]>
npm/ng-packs/packages/core/src/lib/services/replaceable-components.service.ts
Outdated
Show resolved
Hide resolved
…ents.service.ts Co-authored-by: Bunyamin Coskuner <[email protected]>
armanozak
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5026