Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IHtmlGenerator / TagBuilder in all necessary tag helpers #5331

Merged
merged 20 commits into from
Sep 30, 2020
Merged

Use IHtmlGenerator / TagBuilder in all necessary tag helpers #5331

merged 20 commits into from
Sep 30, 2020

Conversation

SecTex
Copy link
Contributor

@SecTex SecTex commented Sep 8, 2020

Fixes #5322

@maliming
Copy link
Member

maliming commented Sep 9, 2020

hi @SecTex

Thanks for your contributions, we have many tag helper so there will be a lot of work. If you don't have much time I can handle it .

@maliming maliming self-requested a review September 9, 2020 03:36
@SecTex
Copy link
Contributor Author

SecTex commented Sep 9, 2020

Hi @maliming

It's fine, I'll take the time to revise all tag helpers.

@SecTex SecTex changed the title Using proper encoding Use IHtmlGenerator / TagBuilder in all necessary tag helpers Sep 9, 2020
@SecTex SecTex marked this pull request as ready for review September 14, 2020 09:38
@maliming maliming added this to the 3.3 milestone Sep 16, 2020
@maliming
Copy link
Member

Thanks @SecTex very much!

maliming
maliming reviewed Sep 16, 2020
View reviewed changes
...ore.Mvc.UI.Theme.Shared/wwwroot/libs/abp/aspnetcore-mvc-ui-theme-shared/toastr/abp-toastr.js Outdated Show resolved Hide resolved
....UI.Theme.Shared/wwwroot/libs/abp/aspnetcore-mvc-ui-theme-shared/jquery/jquery-extensions.js Outdated Show resolved Hide resolved
...e.Shared/wwwroot/libs/abp/aspnetcore-mvc-ui-theme-shared/datatables/datatables-extensions.js Outdated Show resolved Hide resolved
...e.Shared/wwwroot/libs/abp/aspnetcore-mvc-ui-theme-shared/datatables/datatables-extensions.js Outdated Show resolved Hide resolved
...e.Shared/wwwroot/libs/abp/aspnetcore-mvc-ui-theme-shared/datatables/datatables-extensions.js Outdated Show resolved Hide resolved
...e.Shared/wwwroot/libs/abp/aspnetcore-mvc-ui-theme-shared/datatables/datatables-extensions.js Outdated Show resolved Hide resolved
@SecTex
Merge branch 'dev' of https://github.com/abpframework/abp into SecTex…
0e4b6b6 
…/html-encoding

# Conflicts:
#	framework/src/Volo.Abp.AspNetCore.Mvc.UI.Theme.Shared/wwwroot/libs/abp/aspnetcore-mvc-ui-theme-shared/datatables/datatables-extensions.js
@SecTex SecTex requested a review from maliming September 21, 2020 07:23
@maliming maliming requested a review from hikalkan September 24, 2020 02:28
@hikalkan hikalkan requested a review from yekalkan September 30, 2020 12:52
@yekalkan yekalkan merged commit e07e3a3 into abpframework:dev Sep 30, 2020
@hikalkan hikalkan mentioned this pull request Oct 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliming maliming maliming approved these changes

@yekalkan yekalkan yekalkan approved these changes

@hikalkan hikalkan Awaiting requested review from hikalkan

Assignees
No one assigned
Labels
abp-framework enhancement
Projects
None yet
Milestone
3.3-preview
Development

Successfully merging this pull request may close these issues.

Use IHtmlGenerator / TagBuilder in all necessary tag helpers
3 participants
@SecTex @maliming @yekalkan