Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved #4874 #5223

Merged
merged 1 commit into from
Aug 29, 2020
Merged

Resolved #4874 #5223

merged 1 commit into from
Aug 29, 2020

Conversation

armgnunlu
Copy link
Member

No description provided.

@armgnunlu armgnunlu added this to the 3.2 milestone Aug 28, 2020
@armgnunlu armgnunlu requested review from hikalkan and yekalkan August 28, 2020 15:36
@armgnunlu armgnunlu self-assigned this Aug 28, 2020
@hikalkan
Copy link
Member

A better title for the PR: "Implemented: UI Design for CMS Kit reactions & comments".

@hikalkan hikalkan merged commit 78ae854 into dev Aug 29, 2020
@hikalkan hikalkan deleted the au-cms-kit-reactions-comment-design branch August 29, 2020 08:47
@maliming
Copy link
Member

maliming commented Sep 1, 2020

hi

This PR causes the unit test to fail. because the public const string Hooray = "_HO"; has been removed.

https://github.com/abpframework/abp/pull/5223/files#diff-5021f542f11716cae5309ce62dba707e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants