Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced separate commands for adding, removing, and refreshing proxies #5222

Merged
merged 18 commits into from
Aug 29, 2020
Merged

Introduced separate commands for adding, removing, and refreshing proxies #5222

merged 18 commits into from
Aug 29, 2020

Conversation

armanozak
Copy link
Contributor

Fixes #5202
Fixes #5221

Command Names

  • proxy-add
  • proxy-refresh
  • proxy-remove

Parameters

All use the same parameters with the legacy proxy command.

armanozak added 18 commits August 28, 2020 00:47
@armanozak
feat: add proxy config interface to schematics
012137a
@armanozak
feat: convert api definition reader to proxy config reader
fa59ee8
@armanozak
feat: add constant for proxy-config.json path
eff4ad5
@armanozak
feat: use proxy config reader and saver in commands
a4d9df2
@armanozak
feat: rename shared directory as proxy in schametics
87e61eb
@armanozak
feat: add file write exception in schematics
992932a
@armanozak
feat: add type alias for file write operation
3a8fba2
@armanozak
feat: improve proxy config write op in schematics
8870976
@armanozak
refactor: enable creating rule from proxy config writer
fe3aa26
@armanozak
feat: store generated module names in proxy config
c0fd167
@armanozak
feat: add a shared GenerateProxySchema model
738909c
@armanozak
feat: update proxy constants in schematics
6789471
@armanozak
feat: update exceptions in schematics
70f8089
@armanozak
feat: add utility fn for generating multiple APIs
f014680
@armanozak
feat: add chainAndMerge utility rule creator
722145c
@armanozak
feat: create 3 separate commands for proxy generation
7dd5aa7
@armanozak
build: update files to copy after schematics build
c91206d
@armanozak
feat: add a warning about generated proxies in markdown
47b1aa1
@armanozak armanozak added this to the 3.2 milestone Aug 28, 2020
@hikalkan hikalkan merged commit 0d27c0f into rel-3.1 Aug 29, 2020
@hikalkan hikalkan deleted the feat/5202 branch August 29, 2020 08:48
@hikalkan
Copy link
Member

hikalkan commented Aug 31, 2020 •
edited
Loading

  • abp generate-proxy (see) uses the proxy-add
    abp remove-proxy (see, a new command) uses the proxy-remove

No need to call proxy-refresh since both commands do refresh after the actual command. So, in practical, abp generate-proxy refreshed the proxies if you've generated it before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikalkan hikalkan Awaiting requested review from hikalkan

@bnymncoskuner bnymncoskuner Awaiting requested review from bnymncoskuner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@armanozak @hikalkan