CmsKit: Should focus on the comment area after login and return back #5134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikalkan
reviewed
Aug 20, 2020
| return; | ||
| } | ||
|
|
||
| $('html, body').animate({ scrollTop: $(location.hash).offset().top + $(this).height() / 2 }, 'slow'); |
There was a problem hiding this comment.
I think this is very generic code. We should move this to a framework package, or restrict it: apply it only for hashes start with cms-comment.
Also, doesn it cover the "reply" scenario (should focus on the reply)
There was a problem hiding this comment.
Also, doesn it cover the "reply" scenario (should focus on the reply)
It can't focus on reply or a single comment because ReturnUrlHash only has EntityType & EntityId information. So it focuses on the whole related comment area.
Of course If focusing on a reply or single comment is very important, i can do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5073