Revise how to change the password for external logins #4975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yekalkan
changed the title
hikalkan
requested changes
Aug 9, 2020
| var currentUser = await UserManager.GetByIdAsync(CurrentUser.GetId()); | ||
|
|
||
| var profile = ObjectMapper.Map<IdentityUser, ProfileDto>(currentUser); | ||
| profile.IsExternalLoggedIn = currentUser.IsExternal; |
There was a problem hiding this comment.
If you rename profile.IsExternalLoggedIn to currentUser.IsExternal then you don't need to manually map.
| CreateMap<IdentityUser, ProfileDto>() | ||
| .Ignore(x=>x.IsExternalLoggedIn) | ||
| .Ignore(x=>x.HasPassword) |
There was a problem hiding this comment.
Instead of ignoring HasPassword, you can map it with a custom lambda expression that checks PasswordHash != null. In this way, you don't need to manual mapping later.
| profile.IsExternalLoggedIn = currentUser.IsExternal; | ||
| profile.HasPassword = currentUser.PasswordHash != null; | ||
|
|
||
| return profile; |
There was a problem hiding this comment.
After changing the mapping to fully use automapper, you can rollback changes in this method.
hikalkan
requested changes
Aug 9, 2020
|
|
||
| if (currentUser.PasswordHash == null) | ||
| { | ||
| (await UserManager.RemovePasswordAsync(currentUser)).CheckErrors(); |
There was a problem hiding this comment.
Is it really need to UserManager.RemovePasswordAsync. I suppose it is not needed because you are already checking if currentUser.PasswordHash == null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4982