Implemented the getting environment from remote URL

[mehmet-erim]

Resolves #4386

Remote environment configuration can be added to the environment like below:

import { Config } from '@abp/ng.core';

export const environment = {
  production: false,
  hmr: false,
  remoteEnv: {
    url: '/assets/appsettings.json',
    method: 'GET',
    headers: {}
  }
} as Config.Environment;

[olicooper]

My implementation (see here) allowed for partial replacement and appending of nested properties using a package called deepmerge. Is this something you'd be able to add in to make it more flexible and similar to .NET Core's appsettings.json replacement?

I could have the default environment.ts like this:

{
  recaptcha: { enabled: false, siteKey: 'AAAA' }
}

And my /assets/appsettings.json like this:

{
  recaptcha: { enabled: true  },
  anotherSetting: "hi"
}

Which results in:

{
  recaptcha: { enabled: true, siteKey: 'AAAA' },
  anotherSetting: "hi"
}

You don't have to use the deepmerge package, but if you do then I'm not sure how you'd want to handle array merging...
https://github.com/TehShrike/deepmerge#arraymerge

[mehmet-erim]

Hi @olicooper

Thanks for your suggestion. We'll consider this.

[olicooper]

Could you also consider the option to suppress the RestError and gracefully fall back to the default environment configuration if the remoteEnv is not available? Maybe a simple console debug/warning log rather than passing it to the error handler and showing to the end user?

[olicooper]

I have just tried this on a staging environment and found an issue on the Angular UI...

I'm not sure why but the request to /.well-known/openid-configuration is made before the remoteEnv is configured. so the request is made to the wrong API (https://api.app.example.com instead of https://api.staging.example.com).

environment.prod.ts:

{
  oAuthConfig: {
    issuer: 'https://api.app.example.com',
    // etc...
  },
  apis: {
    default: {
      url: 'https://api.app.example.com',
    },
  }
}

appsettings.json:

{
  "oAuthConfig": {
    "issuer": "https://api.staging.example.com",
    // etc...
  },
  "apis": {
    "default": {
      "url": "https://api.staging.example.com"
    }
  }
}

I am using @abp/ng.core 3.1.0-preview20200813

[mehmet-erim]

Could you also consider the option to suppress the RestError and gracefully fall back to the default environment configuration if the remoteEnv is not available? Maybe a simple console debug/warning log rather than passing it to the error handler and showing to the end user?

We will create an injection token to be able to get catch error function from the AppModule. See the related issue: #4992

I will check it. Thanks for the information.

[olicooper]

Perfect, great work! Thank you 👍

[olicooper]

@mehmet-erim I think I have fixed the problem.. #5058