Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EntityTypeBuilder & PropertyBuilder in the MapEfCoreProperty method. #4893

Merged
merged 3 commits into from
Aug 10, 2020

Conversation

maliming
Copy link
Member

@maliming maliming commented Jul 27, 2020

Resolve #4891

This will bring a breaking change.

@hikalkan Do you have any suggested?

@hikalkan
Copy link
Member

hikalkan commented Aug 9, 2020

@maliming instead of the breaking change, please create an overload of this method that gets an action with two arguments.

Copy link
Member

@hikalkan hikalkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of the breaking change, please create an overload of this method that gets an action with two arguments.

@maliming maliming requested a review from hikalkan August 10, 2020 06:32
@hikalkan hikalkan merged commit cbbf56c into dev Aug 10, 2020
@hikalkan hikalkan deleted the maliming/MapEfCoreProperty branch August 10, 2020 14:51
@hikalkan
Copy link
Member

I merged. Can you add [Obsolete] note to the method with action with single parameter? We may remove it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use EntityTypeBuilder and PropertyBuilder in the MapEfCoreProperty method.
2 participants