-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMSKit initial solution is prepared #4750
Conversation
{ | ||
public class AdminPermissions | ||
{ | ||
public const string GroupName = "Admin"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not a good name. Admin
and Public
is too common.has no special meaning.
CmsKit.Admin
is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is a CMS framework or component set like hikalkan's introduction, it may provide abstract entity class, derived repository base class, derived AppService class, UI components, and more.
If so, maybe AdminPermissions
, AdminMenu
, RemoteServiceName
and their classes should not be defined, since it is not an application module and is used to create some other modules or apps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right,
updated by 6d402e4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only initial solution. This will get a lot of update soon. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cotur
AdminMenu
, RemoteServiceName
should also be changed. : ).
L("Permission:Public")
should be L("Permission:CmsKit.Public")
Closes: #4743