Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMSKit initial solution is prepared #4750

Merged
merged 7 commits into from
Jul 14, 2020
Merged

CMSKit initial solution is prepared #4750

merged 7 commits into from
Jul 14, 2020

Conversation

cotur
Copy link
Contributor

@cotur cotur commented Jul 14, 2020

Closes: #4743

@cotur cotur added this to the 3.1 milestone Jul 14, 2020
@cotur cotur requested a review from hikalkan July 14, 2020 09:35
@cotur cotur merged commit 60e0c01 into dev Jul 14, 2020
{
public class AdminPermissions
{
public const string GroupName = "Admin";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not a good name. Admin and Public is too common.has no special meaning.

CmsKit.Admin is better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is a CMS framework or component set like hikalkan's introduction, it may provide abstract entity class, derived repository base class, derived AppService class, UI components, and more.

If so, maybe AdminPermissions, AdminMenu, RemoteServiceName and their classes should not be defined, since it is not an application module and is used to create some other modules or apps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right,

updated by 6d402e4

Copy link
Contributor Author

@cotur cotur Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only initial solution. This will get a lot of update soon. :)

Copy link
Member

@realLiangshiwei realLiangshiwei Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cotur
AdminMenu, RemoteServiceName should also be changed. : ).

L("Permission:Public") should be L("Permission:CmsKit.Public")

@cotur cotur deleted the Cotur/cms-kit branch July 23, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Module: CMS Kit / Prepare the initial solution
3 participants