Cache the AccessToken in IdentityModelAuthenticationService. #4742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikalkan
requested changes
Jul 16, 2020
| var tokenResponse = await GetTokenResponse(discoveryResponse, configuration); | ||
|
|
||
| if (tokenResponse.IsError) | ||
| var cacheKey = CalculateCacheKey(discoveryResponse, configuration); |
There was a problem hiding this comment.
Why not including the GetDiscoveryResponse call to the cached part? Should we always call it?
There was a problem hiding this comment.
Sorry I forgot it, I will cache it.
But can we use configuration.Authority + /connect/token directly? Because this url is seem fixed(not sure), of course, developers can also rewrite the method to call the api.
|
|
||
| public static string CalculateCacheKey(DiscoveryDocumentResponse discoveryResponse, IdentityClientConfiguration configuration) | ||
| { | ||
| return discoveryResponse.TokenEndpoint + string.Join(",", configuration.Select(x => x.Key + ":" + x.Value)); |
There was a problem hiding this comment.
Instead of such a long key (which may have problems with cache providers), can we get MD5 (or use a better algorithm) hash of the string. I am just thiking and not sure about it. What do you think?
There was a problem hiding this comment.
If the name of the key does not need to have any meaning, md5 is no problem.
...work/src/Volo.Abp.IdentityModel/Volo/Abp/IdentityModel/IdentityModelAuthenticationService.cs
Outdated
Show resolved
Hide resolved
hikalkan
requested changes
Aug 11, 2020
framework/src/Volo.Abp.IdentityModel/Volo/Abp/IdentityModel/IdentityClientConfiguration.cs
Outdated
Show resolved
Hide resolved
framework/src/Volo.Abp.IdentityModel/Volo/Abp/IdentityModel/IdentityClientConfiguration.cs
Outdated
Show resolved
Hide resolved
framework/src/Volo.Abp.IdentityModel/Volo/Abp/IdentityModel/IdentityClientConfiguration.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4603