Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soft Delete & Common Test Done for MemoryDB #4453

Merged
merged 3 commits into from
Jun 23, 2020
Merged

Soft Delete & Common Test Done for MemoryDB #4453

merged 3 commits into from
Jun 23, 2020

Conversation

iyilm4z
Copy link
Contributor

@iyilm4z iyilm4z commented Jun 22, 2020

Fixes this.

@iyilm4z iyilm4z changed the title Soft Delete & Common Test Done Soft Delete & Common Test Done for MemoryDB Jun 22, 2020
@maliming maliming self-requested a review June 22, 2020 10:01
@iyilm4z
Copy link
Contributor Author

iyilm4z commented Jun 22, 2020 •
edited
Loading

Hi @maliming build-test step of pipeline failed. However as i can see it's related to Volo.Abp.AspNetCore.Mvc.Tests, not to my changes. Am i right? If not, what i'm missing?

failed-ss

success-ss

@maliming
Copy link
Member

It should be related to your code. You can try to synchronize the code from the dev branch(Merge dev branch to your branch. ).

image

@iyilm4z
Copy link
Contributor Author

iyilm4z commented Jun 22, 2020 •
edited
Loading

@maliming you were right, it was related to my changes. i've synced my feature branch with upstream/dev. I also found this line causes tests failed but i donno why:/ it's just a dependency of IAuditPropertySetter. I also realized that failing tests written by you, that's why you may be tell me the relation.

Base MemoryDbContext is a ISingletonDependency, this may cause the issue?

image

@maliming
Copy link
Member

hi @iyilm4z

It was fixed. 2d2a5cb

@iyilm4z
Copy link
Contributor Author

iyilm4z commented Jun 23, 2020

@maliming thank you. you are so helpful.

@maliming maliming added this to the 3.0 milestone Jun 23, 2020
@maliming maliming merged commit e1f4e0b into abpframework:dev Jun 23, 2020
@maliming
Copy link
Member

@iyilm4z Thank you for your contribution.

@iyilm4z iyilm4z deleted the soft-delete-4-memory-db branch June 23, 2020 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliming maliming maliming approved these changes

Assignees
No one assigned
Labels
abp-framework enhancement
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Implement Soft Delete for the MemoryDB
2 participants
@iyilm4z @maliming