Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make base properties of common base classes protected instead of public #4178

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

maliming
Copy link
Member

@maliming maliming commented Jun 2, 2020

Resolve #3968

@maliming maliming added this to the 3.0 milestone Jun 2, 2020
@maliming maliming marked this pull request as ready for review June 5, 2020 10:03
@maliming maliming requested a review from hikalkan June 5, 2020 10:03
@hikalkan hikalkan merged commit 6904a22 into dev Jun 9, 2020
@hikalkan hikalkan deleted the maliming/protected branch June 9, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make base properties of common base classes protected instead of public
2 participants