Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaginationTagHelper show info bug fix #3538

Closed
wants to merge 1 commit into from
Closed

PaginationTagHelper show info bug fix #3538

wants to merge 1 commit into from

Conversation

ekaradev
Copy link
Member

@ekaradev ekaradev commented Apr 9, 2020

@maliming maliming requested a review from yekalkan April 10, 2020 00:37
@hikalkan hikalkan added this to the 2.6 milestone Apr 12, 2020
@hikalkan hikalkan mentioned this pull request Apr 12, 2020
Closed
@yekalkan
Copy link
Member

Hi @emrekara37

I'm sorry but i will not approve this pr. Because those localizations are needed in datatables and should remain same.

See https://github.com/abpframework/abp/blob/dev/framework/src/Volo.Abp.AspNetCore.Mvc.UI.Theme.Shared/wwwroot/libs/abp/aspnetcore-mvc-ui-theme-shared/datatables/datatables-extensions.js#L350

I'll fix this issue. Thanks for your effort.

@yekalkan yekalkan closed this Apr 13, 2020
@yekalkan yekalkan removed this from the 2.6 milestone Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yekalkan yekalkan Awaiting requested review from yekalkan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekaradev @yekalkan @hikalkan