Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored the internal logic of the AddFileToBundle method. #3529

Closed
wants to merge 1 commit into from
Closed

Refactored the internal logic of the AddFileToBundle method. #3529

wants to merge 1 commit into from

Conversation

maliming
Copy link
Member

@maliming maliming commented Apr 9, 2020

Resolve #3521

@maliming maliming requested a review from hikalkan April 9, 2020 07:45
@maliming maliming added this to the 2.5 milestone Apr 9, 2020
@ebicoglu ebicoglu modified the milestones: 2.5, 2.6 Apr 10, 2020
@hikalkan
Copy link
Member

I didn't like to get GetFileContent multiple times (unnecessarily). I will implement this again. Thanks.

@hikalkan hikalkan closed this Apr 12, 2020
@hikalkan
Copy link
Member

Implemented: b42a6ed

@maliming maliming deleted the maliming/BundlerBase branch April 20, 2020 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikalkan hikalkan Awaiting requested review from hikalkan

Assignees
No one assigned
Labels
abp-framework
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.

bundling module wrong if condition
3 participants
@maliming @hikalkan @ebicoglu