Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an endpoint to query all roles. #2985

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Create an endpoint to query all roles. #2985

merged 2 commits into from
Mar 17, 2020

Conversation

maliming
Copy link
Member

@maliming maliming commented Mar 5, 2020

Resolve #2983

@maliming maliming added this to the 2.3 milestone Mar 5, 2020
@maliming maliming requested a review from hikalkan March 5, 2020 10:24
hikalkan
hikalkan requested changes Mar 5, 2020
View reviewed changes
...ity/src/Volo.Abp.Identity.Application.Contracts/Volo/Abp/Identity/IIdentityRoleAppService.cs Outdated
@@ -8,6 +8,8 @@ namespace Volo.Abp.Identity
{
public interface IIdentityRoleAppService : IApplicationService
{
Task<List<IdentityRoleDto>> GetAllListAsync();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ListResultDto wtihh has Items collection. We use this "wrapping" to be able to add new properties to the object without breaking existing client applications (backward compability).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ListResultDto has been used.

@maliming maliming mentioned this pull request Mar 10, 2020
Closed
@maliming
Copy link
Member Author

@hikalkan Already done.

@hikalkan hikalkan merged commit b7e4bcd into dev Mar 17, 2020
@hikalkan
Copy link
Member

Thanks!

@maliming maliming deleted the maliming/allrole branch March 17, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikalkan hikalkan hikalkan requested changes

Assignees
No one assigned
Labels
abp-module-identity
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

Create an endpoint to query all roles
2 participants
@maliming @hikalkan