Akin/added ordered post list into post app service #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikalkan
requested changes
Mar 2, 2020
| @@ -9,6 +9,8 @@ public interface IPostAppService : IApplicationService | |||
| { | |||
| Task<ListResultDto<PostWithDetailsDto>> GetListByBlogIdAndTagName(Guid blogId, string tagName); | |||
|
|
|||
| Task<ListResultDto<PostDto>> GetOrderedListPostsByTime(); | |||
There was a problem hiding this comment.
Rename to GetTimeOrderedListAsync
There was a problem hiding this comment.
It would be better to reuse PostWithDetailsDto (and fill details).
| @@ -18,6 +18,7 @@ public BloggingApplicationAutoMapperProfile() | |||
| CreateMap<Blog, BlogDto>(); | |||
| CreateMap<BlogUser, BlogUserDto>(); | |||
| CreateMap<Post, PostWithDetailsDto>().Ignore(x=>x.Writer).Ignore(x=>x.CommentCount).Ignore(x=>x.Tags); | |||
| CreateMap<Post, PostDto>().Ignore(x => x.UserName).Ignore(x => x.CommentCount); | |||
There was a problem hiding this comment.
Why added CommentCount if not used?
| return new ListResultDto<PostWithDetailsDto>(postDtos); | ||
| } | ||
|
|
||
| public async Task<ListResultDto<PostDto>> GetOrderedListPostsByTime() | ||
| { | ||
| var posts = (await _postRepository.GetListAsync()).OrderByDescending(x => x.CreationTime).ToList(); |
There was a problem hiding this comment.
Why not ordering in the database? Also, getting all posts (without even a blogId filter) seems wrong to me.
| @@ -27,6 +27,13 @@ public Task<ListResultDto<PostWithDetailsDto>> GetListByBlogIdAndTagName(Guid bl | |||
| return _postAppService.GetListByBlogIdAndTagName(blogId, tagName); | |||
| } | |||
|
|
|||
|
|
|||
| [HttpGet] | |||
| public Task<ListResultDto<PostDto>> GetOrderedListPostsByTime() | |||
There was a problem hiding this comment.
[Route("{blogId}/all/by-time")]
|
@akinix what is the issue related to this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.