Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the script is executed before the callback method. #2854

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Make sure the script is executed before the callback method. #2854

merged 2 commits into from
Feb 19, 2020

Conversation

maliming
Copy link
Member

$.getScript
The callback is fired once the script has been loaded but not necessarily executed.

@maliming maliming requested a review from hikalkan February 18, 2020 11:55
@ebicoglu ebicoglu merged commit 02f5f15 into dev Feb 19, 2020
@ebicoglu ebicoglu deleted the maliming/abp-jquery-script branch February 19, 2020 06:54
@ebicoglu ebicoglu requested review from ebicoglu and removed request for hikalkan February 19, 2020 06:54
@ebicoglu ebicoglu self-assigned this Feb 19, 2020
@ebicoglu ebicoglu added this to the 2.1 milestone Feb 19, 2020
@ebicoglu ebicoglu mentioned this pull request Feb 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebicoglu ebicoglu Awaiting requested review from ebicoglu

Assignees

@ebicoglu ebicoglu

Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@maliming @ebicoglu