-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache docs in local database & topic labels. #2826
Conversation
I want to suggest enhancement about this topic; |
Will topic be marked as UPD If you edit a typo after 30 days? |
We were discussing it today :) We'll try to find a proper way (like the amount of the edit). If you have a good suggestion, it is appreciated. |
I was thinking about settings this up manually in Navigation Document. New json section "labels" or parameter "label" for example. And this problem will be closed for json-based documentation. Hovewer there is a chance that developer will forget to mark upper level nodes, but it's not your problem :) In terms of github-based documentation, I need a bit of research to see what info available. I think New and Upd labels should appear only after version change. So checking edit date is not enough. |
Following with #2843 |
Resolve #2805 , resolve #1994
Store
Document
andDocumentContributors
as entities into the database. Documents have different language codes and versions. RenameIDocumentStore
toIDocumentSource
.Determine whether the file is
Upd
orNew
according to the file's commits.Question: A new document may be modified multiple times in a short time. Although it has multiple commits, it is still a new document.
Question: How many days have a document changed that should show the Upd label. I specify 30 days by default. https://github.com/abpframework/abp/pull/2826/files#diff-7bf979fec9bcb043de25e87457696494R127