Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic C# Api client-side validation. #2550

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Dynamic C# Api client-side validation. #2550

merged 2 commits into from
Jan 7, 2020

Conversation

mehmetuken
Copy link
Contributor

@mehmetuken mehmetuken commented Jan 4, 2020 •
edited
Loading

Resolve #2526

@hikalkan hikalkan self-requested a review January 5, 2020 18:29
@hikalkan hikalkan added this to the 2.0 milestone Jan 5, 2020
@maliming
Copy link
Member

maliming commented Jan 6, 2020

hi @mehmetuken
I haven't researched it in depth, but I think if adding ValidationInterceptor to it can solve this issue?

abp/framework/src/Volo.Abp.Http.Client/Microsoft/Extensions/DependencyInjection/ServiceCollectionDynamicHttpClientProxyExtensions.cs

Line 165 in 88ded4e

(IInterceptor)serviceProvider.GetRequiredService(interceptorAdapterType)

@mehmetuken
Copy link
Contributor Author

Thank you @maliming. It's very clear way. I'm new interceptor concept.

@hikalkan hikalkan merged commit 0d28779 into abpframework:dev Jan 7, 2020
@hikalkan
Copy link
Member

hikalkan commented Jan 7, 2020

Thanks to both of you ;)

@mehmetuken mehmetuken deleted the client-validation branch January 7, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikalkan hikalkan Awaiting requested review from hikalkan

Assignees
No one assigned
Labels
abp-framework feature
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Validate DTOs before server calls on dynamic C# API client
3 participants
@mehmetuken @maliming @hikalkan