Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application shutdown #2528

Merged
merged 5 commits into from
Jan 7, 2020
Merged

Application shutdown #2528

merged 5 commits into from
Jan 7, 2020

Conversation

mehmetuken
Copy link
Contributor

Resolve #265 and #2066

@maliming maliming requested a review from hikalkan January 2, 2020 00:39
@hikalkan hikalkan requested a review from maliming January 2, 2020 05:22
@hikalkan hikalkan added this to the 2.0 milestone Jan 2, 2020
@hikalkan
Copy link
Member

hikalkan commented Jan 2, 2020

Thank you @mehmetuken

@maliming can you review & test this (with a console & web app - use existing sample projects/templates).

@maliming
Copy link
Member

maliming commented Jan 2, 2020

After code review and testing of console and web application I think the code can be merged.

@mehmetuken
Copy link
Contributor Author

mehmetuken commented Jan 2, 2020

AutofacServiceProvider from https://github.com/autofac/Autofac.Extensions.DependencyInjection/blob/master/src/Autofac.Extensions.DependencyInjection/AutofacServiceProvider.cs .
And this change not releated console app. Console apps doesn't yet using generic host. Manually run shutdown metod.

@maliming
Copy link
Member

maliming commented Jan 2, 2020

@mehmetuken
Copy link
Contributor Author

@maliming Yes i am not using IAsyncDisposable because Autofac 5 not release yet. ILifetimeScope not support IAsyncDisposable yet. Autofac 5 release we can update this.

@hikalkan hikalkan merged commit 2d8b349 into abpframework:dev Jan 7, 2020
@hikalkan
Copy link
Member

hikalkan commented Jan 7, 2020

Thank you @mehmetuken & @maliming

@mehmetuken mehmetuken deleted the application-shutdown branch January 7, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage application shutdown (using IApplicationLifetime for aspnet core)
3 participants