Move AbpIntegratedTest to Volo.Abp.Testing namespace #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikalkan
reviewed
Dec 29, 2019
| @@ -2,10 +2,8 @@ | |||
| using Microsoft.Extensions.DependencyInjection; | |||
| using Volo.Abp.Modularity; | |||
|
|
|||
| namespace Volo.Abp | |||
| namespace Volo.Abp.Testing | |||
There was a problem hiding this comment.
When you change this namespace, all the projects/solutions using the AbpIntegratedTest will be broken. So, if we make this change, we should change all modules/templates/samples in this repository. Otherwise, I can not accept this PR :)
There was a problem hiding this comment.
I'm sorry, I'm not testing ,I will testing and send a new pull request.
yekalkan
approved these changes
Dec 30, 2019
hikalkan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abp proxy helper class code refactoring.