Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-design interception & sync/async APIs #2464

Merged
merged 16 commits into from
Dec 25, 2019
Merged

Re-design interception & sync/async APIs #2464

merged 16 commits into from
Dec 25, 2019

Conversation

@hikalkan hikalkan added this to the 2.0 milestone Dec 25, 2019
@hikalkan hikalkan merged commit 88ded4e into dev Dec 25, 2019
@hikalkan hikalkan deleted the remove-async-apis branch December 25, 2019 16:39
@maliming
Copy link
Member

Should I remove these sync repositories methods and then change to async methods?

Tenant FindByName(
string name,
bool includeDetails = true
);
Tenant FindById(
Guid id,
bool includeDetails = true
);
Task<List<Tenant>> GetListAsync(
string sorting = null,
int maxResultCount = int.MaxValue,

public interface IBackgroundJobRepository : IBasicRepository<BackgroundJobRecord, Guid>
{
List<BackgroundJobRecord> GetWaitingList(int maxResultCount);

@gdlcf88
Copy link
Contributor

gdlcf88 commented Dec 26, 2019

Do you have intend to make GetListAsync of CrudAppService to async query? @hikalkan

@hikalkan
Copy link
Member Author

Isn't it already async? Can you write more detail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment