Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set value comparer for ExtraProperties and Properties dictionary. #2462

Merged
merged 11 commits into from
Jan 8, 2020
Merged

Set value comparer for ExtraProperties and Properties dictionary. #2462

merged 11 commits into from
Jan 8, 2020

Conversation

maliming
Copy link
Member

Resolve #2459

@hikalkan hikalkan added this to the 2.0 milestone Dec 25, 2019
@hikalkan hikalkan self-requested a review December 26, 2019 05:51
@hikalkan
Copy link
Member

@maliming & @acjh, I will merge if you are agree on the implementation :)

@hikalkan hikalkan self-assigned this Dec 29, 2019
@maliming
Copy link
Member Author

maliming commented Jan 8, 2020

Thanks @acjh 👍

@hikalkan hikalkan merged commit 6e0c55d into dev Jan 8, 2020
@maliming maliming deleted the maliming/SetValueComparer branch January 8, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acjh acjh acjh left review comments

@hikalkan hikalkan Awaiting requested review from hikalkan

Assignees

@hikalkan hikalkan

Labels
abp-framework enhancement
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

ExtraProperties property requires value comparer.
3 participants
@maliming @hikalkan @acjh