Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mongo repository expression error in AuditLogging module. #2307

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

maliming
Copy link
Member

@maliming maliming commented Dec 4, 2019

MongoDB.Driver's GroupBy method cannot translate DateTime.Property.
eg GroupBy(t => ExecutionTime.Date)

@maliming maliming requested a review from hikalkan December 5, 2019 03:15
@hikalkan hikalkan added this to the 1.1.1 milestone Dec 6, 2019
@hikalkan
Copy link
Member

hikalkan commented Dec 6, 2019

Thanks @maliming. But this will have a performance problem since it brings all audit logs into memory and group in the code.
Can you search on that how we can implement this in MongoDB. We can use Mongo's own API (instead of LINQ), no problem.

@maliming
Copy link
Member Author

maliming commented Dec 7, 2019

I will check it again.

@hikalkan
Copy link
Member

hikalkan commented Dec 9, 2019

Should I merge now?

@maliming
Copy link
Member Author

@hikalkan Yes.

@hikalkan hikalkan merged commit 250ac1a into dev Dec 10, 2019
@hikalkan
Copy link
Member

Thanks @maliming

@maliming maliming deleted the maliming/AuditLoggingMongo branch December 11, 2019 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants