Update Entities.md #2271
Merged
Update Entities.md #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikalkan
reviewed
Nov 30, 2019
docs/en/Entities.md
Outdated
| @@ -59,7 +59,8 @@ Entities with composite keys should implement the `GetKeys()` method as shown ab | |||
|
|
|||
| Notice that you also need to define keys of the entity in your **object-relational mapping** (ORM) configuration. | |||
|
|
|||
| > Composite primary keys has a restriction with repositories. Since it has not known Id property, you can not use `IRepository<TEntity, TKey>` for these entities. However, you can always use `IRepository<TEntity>`. See [repositories documentation](Repositories.md) for more. | |||
| > Also note that Entities with Composite Primary Keys cannot utilize the `IRepository<TEntity, TKey>` interface since it requires a single unique Id property. However, you can always implement `IRepository<TEntity>`. See [repositories documentation](Repositories.md) for more. | |||
There was a problem hiding this comment.
"you can always implement" should be "you can always use", because as you know ABP has generic interfaces already implemented. You can implement it yourself, yes, but it is not so common.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.