Refactor connection string checkers to initialize connection settings within try blocks. #22185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… within try blocks.
realLiangshiwei
approved these changes
Feb 19, 2025
gizemmutukurt
requested review from
oykuermann and
gizemmutukurt
and removed request for
gizemmutukurt and
oykuermann
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
gizemmutukurt
requested review from
gizemmutukurt and
oykuermann
and removed request for
gizemmutukurt
oykuermann
requested changes
Feb 19, 2025
There was a problem hiding this comment.
- MVC - After deleting the connection string, validation error is displayed in the wrong place:
screen-capture.44.webm
- MVC - After unchecking 'Use the shared database', validation error message is displayed:
screen-capture.43.webm
- Blazor Server - Connection string validation message seems like success:
- Validation error message should be displayed when the connection string field is empty.
screen-capture.45.webm
|
Please pull the latest of Volo(https://github.com/volosoft/volo/pull/19376). The UI has changed. And the test case is https://github.com/volosoft/volo/issues/19409#issue-2860236968 |
oykuermann
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's the same as #22146 but targeted to 9.1