fix(theme-shared):fix #2107,when use Esc key to close modal ,should trigger destroy to avoid raise an error

[yinchang0626]

fix #2107
when use Esc key to close modal ,should trigger destroy to avoid raise an error

[mehmet-erim]

You should add in the visible setter. It's enough and correct way

After your changes, 46th - 49th lines should be like this:

else {
 this.renderer.removeClass(document.body, 'modal-open');
 this.disappear.emit();
 this.destroy.next();
 this.destroy.complete();
}

[yinchang0626]

@mehmet-erim
thank for helping, i think you are right
I tried that way you say to fix,
when i test that code:
move code to visible setter is no problem,
but it appear error in this:

else {
 this.renderer.removeClass(document.body, 'modal-open');
 this.disappear.emit();
 this.destroy$.next();
 this.destroy$.complete();
}

and work in this

else {
 this.renderer.removeClass(document.body, 'modal-open');
 this.disappear.emit();
 this.destroy$.next();
}

I dont know why after call complete()
takeUntil(this.destroy$) will still triger the keyup event
if you has suggest ,pls let me know,
I will change it to

else {
 this.renderer.removeClass(document.body, 'modal-open');
 this.disappear.emit();
 this.destroy$.next();
}