Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Part-I.md #2112

Closed
wants to merge 1 commit into from
Closed

Update Part-I.md #2112

wants to merge 1 commit into from

Conversation

xyfy
Copy link
Contributor

@xyfy xyfy commented Nov 7, 2019

fixed the layout component

If this is not done here, the delete pop-up box in Part II: Create, Update and Delete books will not appear

@xyfy
Update Part-I.md
120fd8c 
fixed the layout component 

If this is not done here, the delete pop-up box in Chapter 2 will not appear
@hikalkan hikalkan requested a review from mehmet-erim November 7, 2019 15:16
@hikalkan hikalkan added this to the 1.1 milestone Nov 7, 2019
@mehmet-erim
Copy link
Contributor

See the app-routing.module.ts. BooksModule wrapped with the ApplicationLayoutComponent

@mehmet-erim mehmet-erim closed this Nov 8, 2019
@xyfy xyfy deleted the patch-2 branch November 8, 2019 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehmet-erim mehmet-erim Awaiting requested review from mehmet-erim

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@xyfy @mehmet-erim @hikalkan