Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular - Update Toastr Styles #20494

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Angular - Update Toastr Styles #20494

merged 3 commits into from
Aug 19, 2024

Conversation

sumeyyeKurtulus
Copy link
Contributor

Description

Resolves the latest toastr styles. Here is a demonstration sample

image

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

@sumeyyeKurtulus sumeyyeKurtulus added this to the 9.0-preview milestone Aug 13, 2024
gizemmutukurt
gizemmutukurt requested changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@gizemmutukurt gizemmutukurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can improve the alignment between the icon and the text.

image

gizemmutukurt
gizemmutukurt requested changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@gizemmutukurt gizemmutukurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distance between icon and text should be shortened a little bit.
image

@gizemmutukurt gizemmutukurt merged commit cdc6e74 into dev Aug 19, 2024
2 of 3 checks passed
@gizemmutukurt gizemmutukurt deleted the issue-toastrUpdates branch August 19, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gizemmutukurt gizemmutukurt gizemmutukurt approved these changes

@masum-ulu masum-ulu masum-ulu approved these changes

Assignees
No one assigned
Labels
enhancement ui-angular
Projects
None yet
Milestone
9.0-preview
Development

Successfully merging this pull request may close these issues.
3 participants
@sumeyyeKurtulus @masum-ulu @gizemmutukurt