Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Rendering Custom JSON Sections Starting with "```" #20325

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

salihozkara
Copy link
Member

@salihozkara salihozkara commented Jul 29, 2024

Description

This PR addresses the issue where custom sections (e.g., docs-params section) that start and end with ```` were being detected and rendered correctly, but sections starting with ``` were not being recognized and were rendered as normal markdown. With this PR, custom JSON sections that start with ``` will also be rendered correctly.

This change aims to improve user experience by allowing for more flexible definition and rendering of custom JSON sections.

Checklist

  • I fully tested it as developer

@salihozkara salihozkara added this to the 9.0-preview milestone Jul 29, 2024
@salihozkara salihozkara requested a review from EngincanV July 29, 2024 16:53
@salihozkara salihozkara changed the title Support for Rendering Custom JSON Sections Starting with ` Support for Rendering Custom JSON Sections Starting with "```" Jul 29, 2024
@EngincanV EngincanV requested a review from gizemmutukurt July 30, 2024 12:13
@gizemmutukurt gizemmutukurt requested review from oykuermann and gizemmutukurt and removed request for gizemmutukurt and oykuermann July 31, 2024 07:36
@gizemmutukurt gizemmutukurt merged commit 701cc9f into dev Aug 2, 2024
3 checks passed
@gizemmutukurt gizemmutukurt deleted the salihozkara/ImproveDocsSection branch August 2, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants