Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenIddict to 5.5.0. #19626

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Update OpenIddict to 5.5.0. #19626

merged 2 commits into from
Apr 29, 2024

Conversation

maliming
Copy link
Member

Resolve #19620

I have tested the OpenID Connect login.

@maliming maliming requested a review from salihozkara April 26, 2024 07:49
@maliming maliming added this to the 8.3-preview milestone Apr 26, 2024
@hikalkan
Copy link
Member

Can we move this to 8.2?

@kevinchalet
Copy link

kevinchalet commented Apr 26, 2024

Hey,

Hope you're doing well 👋🏻

FYI, OpenIddict 5.5.0 - released yesterday - still targets IdentityModel 7.4.1 (with all the bugs recently caused by mismatched IdentityModel package versions, I'm now a bit reluctant to bump them 😅).

I see that your Directory.Packages.props references the 7.5.1 version: if it's not already the case, I encourage you to to add explicit, direct references to IdentityModel 7.5.1 in the projects that depend on OpenIddict or the MSFT OIDC or JWT handlers, to avoid any IM version mismatch (which always results in very weird, super hard-to-find bugs 😅)

Here's the 3 IM packages OpenIddict 5.5.0 references: https://github.com/openiddict/openiddict-core/blob/5.5.0/Directory.Packages.props#L334-L336

All the best.

Resolve #19620

I have tested the `OpenID Connect` login.
@maliming maliming changed the base branch from dev to prerel-8.2 April 27, 2024 00:51
@maliming maliming modified the milestones: 8.3-preview, 8.2-final Apr 27, 2024
@maliming
Copy link
Member Author

Thanks @kevinchalet

We have used the latest(7.5.1) packages in MSFT OIDC and JWT projects.

@kevinchalet
Copy link

We have used the latest(7.5.1) packages in MSFT OIDC and JWT projects.

👍🏻

(I'll likely bump IdentityModel in the next OpenIddict version, once we're sure there's no weird thing happening 🤣)

@maliming
Copy link
Member Author

Can we move this to 8.2?

I have changed the target to prerel-8.2.

@salihozkara salihozkara merged commit fd7357e into prerel-8.2 Apr 29, 2024
3 checks passed
@salihozkara salihozkara deleted the OpenIddict-5.5.0 branch April 29, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update OpenIddict to latest(5.5.0)
4 participants