Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default padding to .tab-content as LeptonX does #19475

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

enisn
Copy link
Member

@enisn enisn commented Apr 2, 2024

Description

Resolves https://github.com/volosoft/volo/issues/14922

old
image

new
image

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

How to test it?

Please describe how this can be tested by the test engineers if it is not already explicit - or remove this section if no need to description.

Breaking-Change

It may cause existing designs which includes Tabs. All the .tab-content elements now have 1.5rem padding from up & down. It may cause unwanted spaces after update with the Basic Theme

@enisn enisn added this to the 8.2-preview milestone Apr 2, 2024
@enisn enisn requested a review from gizemmutukurt April 2, 2024 12:43
@enisn enisn marked this pull request as ready for review April 2, 2024 13:02
@gizemmutukurt gizemmutukurt merged commit 4f77a46 into dev Apr 2, 2024
2 checks passed
@gizemmutukurt gizemmutukurt deleted the basic-theme-fixes branch April 2, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants