Adding constants to theme-shared module for error messages by status code #19421

yusuf-cirak · 2024-03-26T13:07:54Z

Resolves #19416

Adding constant to reduce switch-case based code and improve code quality.
Refactoring http-error-wrapper component with the latest features of Angular 17.1
Formatting the current code with Prettier

Go to http://localhost:4200/error?status=404 or http://localhost:4200/error. If an error component is rendered, there is no issue.

…constants

oykuermann

yusuf-cirak and others added 2 commits March 25, 2024 21:17

refactor: http-error-wrapper component and adding http error message …

9164f95

…constants

remove: duplicated contant exports

97fc5d1

yusuf-cirak added this to the 8.1-final milestone Mar 26, 2024

yusuf-cirak requested review from masum-ulu and oykuermann March 26, 2024 13:07

yusuf-cirak added the ui-angular label Mar 26, 2024

masum-ulu approved these changes Mar 26, 2024

View reviewed changes

oykuermann requested changes Mar 28, 2024

View reviewed changes

yusuf-cirak and others added 4 commits March 28, 2024 14:40

Update goHome() function in http-error-wrapper.component.html

30b9969

refactore: error-wrapper component and create-error-comp service

05212db

fix: navigate attempt to unauthorized page after navigation to home

c5b792b

refactor: http-error-wrapper component

58fafb5

masum-ulu requested review from oykuermann and removed request for oykuermann March 28, 2024 13:07

oykuermann approved these changes Mar 28, 2024

View reviewed changes

masum-ulu merged commit 4508248 into rel-8.1 Mar 28, 2024
2 of 3 checks passed

masum-ulu deleted the issue-19416 branch March 28, 2024 13:16

Provide feedback