Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding constants to theme-shared library, refactoring error-wrapper component #19417

Closed
wants to merge 2 commits into from

Conversation

yusuf-cirak
Copy link
Contributor

Description

Resolves #19416

  • Adding constant to reduce switch-case based code and improve code quality.
  • Refactoring http-error-wrapper component with the latest features of Angular 17.1
  • Formatting the current code with Prettier

Checklist

  • I fully tested it as developer

How to test it?

  • Open the web application, go to localhost:4200/error and click Go Back Home button.

</div>
<div class="error-actions">
@if (isHomeShow) {
<a (click)="destroy()" routerLink="/" class="btn btn-primary btn-md mt-2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not you use goHome ? 🤔

@masum-ulu masum-ulu deleted the issue-19416-2 branch March 28, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding constants to theme-shared module for error messages by status code
2 participants