Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close button to PageAlert component. #19388

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

maliming
Copy link
Member

@maliming maliming commented Mar 22, 2024

Fix #19374

image

@maliming maliming added this to the 8.0-patch milestone Mar 22, 2024
@maliming maliming marked this pull request as ready for review March 22, 2024 09:19
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.55%. Comparing base (4b4bbfd) to head (36f3fce).
Report is 5 commits behind head on rel-8.0.

Additional details and impacted files
@@           Coverage Diff            @@
##           rel-8.0   #19388   +/-   ##
========================================
  Coverage    51.55%   51.55%           
========================================
  Files         3080     3080           
  Lines        97413    97413           
  Branches      7776     7776           
========================================
  Hits         50222    50222           
  Misses       45640    45640           
  Partials      1551     1551           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@realLiangshiwei realLiangshiwei merged commit f50cbc6 into rel-8.0 Mar 22, 2024
6 checks passed
@realLiangshiwei realLiangshiwei deleted the maliming-patch-3 branch March 22, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants