Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Newtonsoft with System.Text.Json in PackageVersionCheckerService. #19382

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

maliming
Copy link
Member

@maliming maliming commented Mar 22, 2024

The JsonProperty is from Newtonsoft but the JsonSerializer is System.Text.Json

https://support.abp.io/QA/Questions/6909/commercial-nuget-feed-returns-404-errors

@maliming maliming added this to the 8.1-final milestone Mar 22, 2024
@maliming maliming requested a review from EngincanV March 22, 2024 05:18
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 51.66%. Comparing base (27f84ab) to head (4672bad).
Report is 3 commits behind head on rel-8.1.

Files Patch % Lines
...lo/Abp/Cli/Version/PackageVersionCheckerService.cs 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           rel-8.1   #19382      +/-   ##
===========================================
- Coverage    51.67%   51.66%   -0.01%     
===========================================
  Files         3096     3096              
  Lines        98266    98274       +8     
  Branches      7852     7853       +1     
===========================================
- Hits         50775    50773       -2     
- Misses       45938    45947       +9     
- Partials      1553     1554       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EngincanV EngincanV merged commit a59e43c into rel-8.1 Mar 22, 2024
3 of 5 checks passed
@EngincanV EngincanV deleted the PackageVersionCheckerService branch March 22, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants