Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Check HttpApi.Host project if exists for SignalR nuget package target to add the related package to the project #19348

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

EngincanV
Copy link
Member

@EngincanV EngincanV commented Mar 19, 2024

Description

Related with https://github.com/volosoft/volo/issues/17053#issuecomment-1988337803

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

@EngincanV EngincanV added this to the 8.2-preview milestone Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 51.56%. Comparing base (5beaad5) to head (78c7035).
Report is 2 commits behind head on dev.

Files Patch % Lines
.../Volo/Abp/Cli/ProjectModification/ProjectFinder.cs 0.00% 2 Missing ⚠️
...Abp/Cli/ProjectModification/SolutionModuleAdder.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #19348   +/-   ##
=======================================
  Coverage   51.56%   51.56%           
=======================================
  Files        3098     3098           
  Lines       98532    98532           
  Branches     7877     7877           
=======================================
+ Hits        50804    50810    +6     
+ Misses      46162    46157    -5     
+ Partials     1566     1565    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants