Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid lepton-x package version in all repository after deployment #19276

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

masum-ulu
Copy link
Member

Description

Resolves #19275

  • This PR will solve lepton-x package's invalid version after deployment
  • We need to pass lepton-x version as argument to publish-ng.ps1 file

I've create a TS file for update lepton-x packages version, It depends on the change-package-version.ts

Checklist

  • I fully tested it as developer / designer and created unit / integration tests

How to test it?

  • I've run verdaccio at my local
  • Updated .npmrc file in ng-packs folder and copy this file under to modules folder
  • Run publish-mvc.ps1 with args: .\publish-mvc.ps1 8.1.0-rc.3 http://localhost:4873
  • Run publish-ng.ps1 with args: .\publish-mvc.ps1 8.1.0-rc.3 http://localhost:4873 3.1.0-rc.3
    • The third argument 3.1.0-rc.3 will be lepton-x version for npm packages in repository

@masum-ulu masum-ulu added ui-common Issues that has an effect on multiple frontends such as shared packages and common problems devops labels Mar 12, 2024
@masum-ulu masum-ulu added this to the 8.1-final milestone Mar 12, 2024
@masum-ulu masum-ulu requested review from ebicoglu and skoc10 March 12, 2024 19:59
@ebicoglu ebicoglu merged commit 7ea9d98 into rel-8.1 Mar 13, 2024
2 checks passed
@ebicoglu ebicoglu deleted the issue-19275 branch March 13, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops ui-common Issues that has an effect on multiple frontends such as shared packages and common problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants