Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flag-icon property from the ILanguageInfo #19222

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

EngincanV
Copy link
Member

@EngincanV EngincanV commented Mar 6, 2024

The FlagIcon property has been removed from the ILanguageInfo interface. No need for this property, since we removed the flag icon library from all of our themes and none of them using it now.


Breaking Change

If the flag icon has been specified while defining the localization languages, then it should be removed:

        Configure<AbpLocalizationOptions>(options =>
        {
-           options.Languages.Add(new LanguageInfo("hi", "hi", "Hindi", "in"));
+          options.Languages.Add(new LanguageInfo("hi", "hi", "Hindi"));
             //...
        }

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.55%. Comparing base (436b00d) to head (4323e0b).
Report is 28 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #19222   +/-   ##
=======================================
  Coverage   51.55%   51.55%           
=======================================
  Files        3097     3097           
  Lines       98420    98417    -3     
  Branches     7862     7862           
=======================================
  Hits        50741    50741           
+ Misses      46120    46116    -4     
- Partials     1559     1560    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants