Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy serialization feature Exception.Exception(SerializationInfo, StreamingContext) which is obsolete. #19192

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

takato1314
Copy link
Contributor

@takato1314 takato1314 commented Mar 2, 2024

Description

Resolves #19189

Applies the best practices for removing legacy serialization infrastructure (the infrastructure which supports SerializableAttribute and ISerializable, along with infrastructure which supports BinaryFormatter) which has been obsoleted by the .netcore team for .net 8+.

Breaking changes

Any existing applications which uses the base exception class (i.e. Volo.Abp.BusinessExpception) will need to remove the ctor implementation of Exception(SerializationInfo info, StreamingContext context).

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (I will create a separate documentation issue)

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.56%. Comparing base (8617efd) to head (c56a5f9).
Report is 42 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #19192      +/-   ##
==========================================
- Coverage   51.62%   51.56%   -0.07%     
==========================================
  Files        3097     3097              
  Lines       98282    98420     +138     
  Branches     7853     7862       +9     
==========================================
+ Hits        50736    50746      +10     
- Misses      45987    46115     +128     
  Partials     1559     1559              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliming maliming self-requested a review March 3, 2024 13:07
@maliming maliming added this to the 8.2-preview milestone Mar 4, 2024
@takato1314 takato1314 changed the title Remove more obsolete exception as stated in #19190 Remove legacy serialization feature 'Exception.Exception(SerializationInfo, StreamingContext)' is obsolete Mar 4, 2024
@takato1314 takato1314 changed the title Remove legacy serialization feature 'Exception.Exception(SerializationInfo, StreamingContext)' is obsolete Remove legacy serialization feature 'Exception.Exception(SerializationInfo, StreamingContext)' which is obsolete Mar 4, 2024
@takato1314
Copy link
Contributor Author

Hi @maliming , apologize for the fail build. I have fixed it and currently running the build and test scripts locally first.

@maliming maliming changed the title Remove legacy serialization feature 'Exception.Exception(SerializationInfo, StreamingContext)' which is obsolete Remove legacy serialization feature Exception.Exception(SerializationInfo, StreamingContext) which is obsolete. Mar 4, 2024
@maliming maliming merged commit 436b00d into abpframework:dev Mar 5, 2024
3 of 4 checks passed
@maliming
Copy link
Member

maliming commented Mar 5, 2024

Thanks @takato1314 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning SYSLIB0051: 'Exception.Exception(SerializationInfo, StreamingContext)' is obsolete
2 participants