-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy serialization feature Exception.Exception(SerializationInfo, StreamingContext)
which is obsolete
.
#19192
Merged
maliming
merged 6 commits into
abpframework:dev
from
takato1314:fix/19190_remove_obsolete
Mar 5, 2024
Merged
Remove legacy serialization feature Exception.Exception(SerializationInfo, StreamingContext)
which is obsolete
.
#19192
maliming
merged 6 commits into
abpframework:dev
from
takato1314:fix/19190_remove_obsolete
Mar 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #19192 +/- ##
==========================================
- Coverage 51.62% 51.56% -0.07%
==========================================
Files 3097 3097
Lines 98282 98420 +138
Branches 7853 7862 +9
==========================================
+ Hits 50736 50746 +10
- Misses 45987 46115 +128
Partials 1559 1559 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alex Soh <[email protected]>
Hi @maliming , apologize for the fail build. I have fixed it and currently running the build and test scripts locally first. |
…s reverted partially but forgot to remove the Serializable attribute
Exception.Exception(SerializationInfo, StreamingContext)
which is obsolete
.
maliming
approved these changes
Mar 5, 2024
Thanks @takato1314 👍 |
This was referenced Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #19189
Applies the best practices for removing legacy serialization infrastructure (the infrastructure which supports SerializableAttribute and ISerializable, along with infrastructure which supports BinaryFormatter) which has been obsoleted by the .netcore team for .net 8+.
Breaking changes
Any existing applications which uses the base exception class (i.e. Volo.Abp.BusinessExpception) will need to remove the ctor implementation of
Exception(SerializationInfo info, StreamingContext context)
.Checklist