Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default className if group.name doesn't defined in prop #19135

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

Sinan997
Copy link
Contributor

@Sinan997 Sinan997 commented Feb 26, 2024

GroupedFormPropList class was grouping under the undefined object if group.name wasn't defined in prop.

This pr sets a default className for prop if group.name is undefined.

Note

Edited by @masumulu28

We will try to manage input order (with and without group) adding group property, if it's not possible we'll accept this default behavior.

@Sinan997 Sinan997 added this to the 8.1-final milestone Feb 26, 2024
@Sinan997 Sinan997 requested a review from masum-ulu February 26, 2024 15:17
@Sinan997 Sinan997 self-assigned this Feb 26, 2024
@masum-ulu masum-ulu marked this pull request as ready for review February 29, 2024 06:35
@masum-ulu masum-ulu merged commit eda22ac into rel-8.1 Feb 29, 2024
3 of 4 checks passed
@masum-ulu masum-ulu deleted the sinan/formprop branch February 29, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants