Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to parse datetime using CurrentUICulture. #19031

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

maliming
Copy link
Member

No description provided.

@maliming maliming added this to the 8.0-patch milestone Feb 15, 2024
@maliming maliming requested a review from ismcagdas February 15, 2024 03:01
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (d42e810) 51.53% compared to head (3f805ac) 51.54%.
Report is 15 commits behind head on rel-8.0.

Files Patch % Lines
...e/Volo/Abp/DynamicProxy/DynamicProxyIgnoreTypes.cs 0.00% 10 Missing ⚠️
...Abp/AspNetCore/Mvc/ConventionalController_Tests.cs 0.00% 6 Missing ⚠️
...Volo.Abp.Core/Volo/Abp/DynamicProxy/ProxyHelper.cs 0.00% 3 Missing ⚠️
...temTextJson/JsonConverters/AbpDateTimeConverter.cs 57.14% 1 Missing and 2 partials ⚠️
...son/JsonConverters/AbpNullableDateTimeConverter.cs 57.14% 1 Missing and 2 partials ⚠️
.../Abp/TestApp/Application/ConventionalAppService.cs 0.00% 3 Missing ⚠️
.../Cli/ProjectModification/PackagePreviewSwitcher.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           rel-8.0   #19031      +/-   ##
===========================================
+ Coverage    51.53%   51.54%   +0.01%     
===========================================
  Files         3078     3080       +2     
  Lines        97414    97400      -14     
  Branches      7779     7776       -3     
===========================================
+ Hits         50200    50207       +7     
+ Misses       45668    45640      -28     
- Partials      1546     1553       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliming maliming requested review from realLiangshiwei and removed request for ismcagdas February 16, 2024 11:26
@realLiangshiwei realLiangshiwei merged commit 8ceb640 into rel-8.0 Feb 16, 2024
4 of 5 checks passed
@realLiangshiwei realLiangshiwei deleted the AbpDateTimeConverter branch February 16, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants